-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Remove 'pip install' options in recipes #5541
base: main
Are you sure you want to change the base?
docs: Remove 'pip install' options in recipes #5541
Conversation
We require contributors to sign our Contributor License Agreement and we don't have one on file for @matthewfeickert. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1062), and ping the bot to refresh the PR. |
5e9d127
to
9e8eda0
Compare
I've signed the CLA. Please merge conda/infrastructure#1062. |
* Remove --no-deps, --no-build-isolation, and --ignore-installed 'pip install' options in recipes as conda-build will enforce all required 'pip install' options itself at build time. * Add corresponding news item.
9e8eda0
to
9be669d
Compare
@conda-bot check |
CodSpeed Performance ReportMerging #5541 will not alter performanceComparing Summary
|
Thanks for taking care of my CLA, @jezdez. This is ready for review now. cc @beckermr @kenodegard also given their recent PR review/merge activity. |
@matthewfeickert Could you please open a ticket that describes the overarching reason we're doing this, basically what is being discussed in conda/grayskull#582? This would be for record-keeping that this is an ecosystem-wide alignment to remove the explicit pip arguments. |
No need to cc anyone, the @conda/builds-tools is automatically assigned and informed. |
Sure. Done in Issue #5543.
Ah cool. I didn't realize that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from me, but we should wait for others.
--no-deps
,--no-build-isolation
, and--ignore-installed
pip install
options in recipes asconda-build
will enforce all requiredpip install
options itself at build time.c.f.
conda-build/conda_build/build.py
Lines 3020 to 3024 in 0ad4bb6
c.f. Question: why is --no-deps --no-build-isolation set? grayskull#582 for motivation and discussion.
Reverts Conform to recipe standards #4960
Description
Checklist - did you ...
news
directory (using the template) for the next release's release notes?