Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE_ environment variables #978

Merged
merged 9 commits into from
May 27, 2016
Merged

FEATURE_ environment variables #978

merged 9 commits into from
May 27, 2016

Conversation

ilanschnell
Copy link
Contributor

@ilanschnell ilanschnell commented May 25, 2016

In this PR, I want to make it easier to create recipes with support features. By setting FEATURE_* environment variables, the user can select whatever feature they need for building a recipe with and without that feature enabled.
For example, having FEATURE_DEBUG=0 will add the debug variable (set to False) to the selector namespace, and set DEBUG=0 in the environment of the build script.

It is also important to see that during building and testing, the feature is enabled (when set to 1).

@teoliphant teoliphant added the in_progress [deprecated] use milestones/project boards label May 25, 2016
@msarahan
Copy link
Contributor

This is a good idea, much in line with #848. I don't think environment variables are the best way to do this, though. I'm going to ponder this, review the code, and try to incorporate it with my efforts to incorporate #848 ( #966 )

@msarahan
Copy link
Contributor

Thanks @ilanschnell - merging.

For those observing, we had a meeting where I asked Ilan not to generalize this PR, so that it did not conflict in spirit with the discussions from #848 et al. This PR is necessary to push forward with our internal goal of making our legacy build recipes into conda recipes. We anticipate that the syntax that this PR supports will eventually be supplanted by the final implementation of proposals from earlier discussion about customizing build pinning, features/variants, compilers, and the rest.

@msarahan msarahan merged commit eca8aa7 into master May 27, 2016
@msarahan msarahan deleted the ilan/select-feat branch May 27, 2016 21:05
@ilanschnell
Copy link
Contributor Author

Thanks for merging!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label May 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in_progress [deprecated] use milestones/project boards locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants