don't use long prefix on windows #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 11.8%@@ master #985 diff @@
==========================================
Files 42 42
Lines 5381 5381
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 635 635
Misses 4746 4746
Partials 0 0
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows paths have a shorter max length than *nix. The long prefix stuff is for the sake of binary path embedding, which is not relevant to Windows. This avoids issues where users set the binary prefix to True, and then the recipe breaks on Windows. Nicer than requiring everyone to have selectors for unix on these things, IMHO.