Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] Test/fix header finding with Python 3.4/vs2010 #995

Merged
merged 8 commits into from
Jun 6, 2016

Conversation

msarahan
Copy link
Contributor

@msarahan msarahan commented Jun 3, 2016

intended to get to root of #993. This test passes on my system, but my system has VS2010 proper, and does not use the Win 7 SDK. Appveyor is really the definitive test here.

Fixes #993 (or rather, will, once this PR is done)

CC @jakirkham

@msarahan msarahan force-pushed the test_header_finding branch from cf594ff to c685076 Compare June 3, 2016 20:24
@msarahan msarahan closed this Jun 3, 2016
@msarahan msarahan reopened this Jun 3, 2016
@msarahan msarahan force-pushed the test_header_finding branch from c685076 to 36f88a1 Compare June 3, 2016 20:25
msarahan added 3 commits June 3, 2016 15:47
- add has_vcs_metadata function for when download is needed
- pin libpng to make tests pass
@msarahan msarahan force-pushed the test_header_finding branch from 06f36a0 to bf69e2f Compare June 6, 2016 01:40
@msarahan
Copy link
Contributor Author

msarahan commented Jun 6, 2016

Original issue here was mismatched quotes in meta.yaml: https://github.com/conda-forge/staged-recipes/pull/695/files#r65830245

Remaining appveyor tests are SVN broken and git file permissions error on test cleanup. Leaving those for another PR.

Merging the fixes here.

@msarahan msarahan merged commit 19731cf into conda:master Jun 6, 2016
@msarahan msarahan deleted the test_header_finding branch June 6, 2016 02:19
@github-actions github-actions bot added the locked [bot] locked due to inactivity label May 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conda-build 1.20.3 and Python 3.4 32-bit fail to build pyyaml on Windows/AppVeyor
1 participant