Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ruff --fix; adjust log calls; remove obsolete test #128

Merged
merged 4 commits into from
Oct 12, 2023
Merged

use ruff --fix; adjust log calls; remove obsolete test #128

merged 4 commits into from
Oct 12, 2023

Conversation

dholth
Copy link
Contributor

@dholth dholth commented Oct 11, 2023 •
edited
Loading

Description

New non-toolz implementation has been shown to work; remove test.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Oct 11, 2023
@dholth dholth changed the title remove obsolete test_groupby_strategies use ruff --fix; adjust log calls; remove obsolete test Oct 11, 2023
@dholth dholth requested review from barabo and kenodegard October 11, 2023 21:33
kenodegard
kenodegard reviewed Oct 11, 2023
View reviewed changes
conda_index/utils.py Outdated Show resolved Hide resolved
conda_index/utils.py Outdated Show resolved Hide resolved
tests/gen_patch.py Outdated Show resolved Hide resolved
tests/gen_patch_2.py Outdated Show resolved Hide resolved
tests/test_coverage.py Outdated Show resolved Hide resolved
@dholth @kenodegard
Apply suggestions from code review
7717dac 
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
@dholth dholth enabled auto-merge (squash) October 12, 2023 00:24
@dholth dholth requested a review from kenodegard October 12, 2023 13:02
@dholth dholth merged commit c267b1f into main Oct 12, 2023
7 checks passed
@dholth dholth deleted the improve-test-coverage-2 branch October 12, 2023 14:58
@dholth
Copy link
Contributor Author

dholth commented Oct 12, 2023

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Oct 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kenodegard kenodegard kenodegard approved these changes

@barabo barabo Awaiting requested review from barabo

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
🔎 Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dholth @kenodegard @conda-bot