Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coverage #145

Merged
merged 7 commits into from
Apr 1, 2024
Merged

Improve coverage #145

merged 7 commits into from
Apr 1, 2024

Conversation

dholth
Copy link
Contributor

@dholth dholth commented Apr 1, 2024

Description

Coverage-related changes from #143. After #143 we will have 100% coverage except for utility and install-plugin-hook code.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 1, 2024
@dholth dholth requested a review from kenodegard April 1, 2024 17:16
@dholth dholth enabled auto-merge (squash) April 1, 2024 17:17
Comment on lines +564 to +566
record[field_name] = (
("".join(record[field_name])).strip().replace("\n", " ")
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
record[field_name] = (
("".join(record[field_name])).strip().replace("\n", " ")
)
record[field_name] = (
"".join(record[field_name]).strip().replace("\n", " ")
)

@dholth dholth merged commit 466a824 into main Apr 1, 2024
21 checks passed
@dholth dholth deleted the 143-improve-coverage branch April 1, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants