Protect against unordered extras in pip dependencies #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg_resources.Requirement.parse does not enforce that pip extras specifiers are ordered on output This addresses conda#449
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Very nice!!! Thanks for this. One very minor suggestion: I think this test would fit better under the newly created |
|
Ok, I'll make the change |
|
Sorry about the failing Windows test. Attempted fix in #451, and feel free to ignore those failures. |
|
Done. I think this is ready |
|
Thanks @AlbertDeFusco!!! |
This was referenced Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By sorting the extras in VersionedDependency this should help addresses hash instability as mentioned in #449.