Support Multiple Categories for Sub-Dependencies in Lockfile (Rebase #390) #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Srinivas Lade <srinulade1@gmail.com>
Co-authored-by: Srinivas Lade <srinulade1@gmail.com>
Co-authored-by: Srinivas Lade <srinulade1@gmail.com>
Co-authored-by: Srinivas Lade <srinulade1@gmail.com>
maresb
force-pushed
the
multiple-categories
branch
from
dd8e2a4
to
c94113f
Compare
|
I was having trouble understanding the totality of your first commit, so I broke it up into 8 separate steps in #589. I just rebased that into this branch, setting you as coauthor on all the commits. |
|
Something went wrong with the tests since my rebase. I have a suspicion... |
|
That turned it green again! 🎉 Now I need to understand what's going on... |
Co-authored-by: Srinivas Lade <srinulade1@gmail.com>
Co-authored-by: Srinivas Lade <srinulade1@gmail.com>
Co-authored-by: Srinivas Lade <srinulade1@gmail.com>
Co-authored-by: Srinivas Lade <srinulade1@gmail.com>
Also change default categories value from `{'main'}` to empty set
because we add instead of overwrite when we apply the categories.
maresb
force-pushed
the
multiple-categories
branch
from
8651b20
to
bd2043a
Compare
This was referenced Sep 13, 2024
|
LET'S DO THIS!!!!! We should look at #300. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@srilman, 🤯 I can't believe that #390 rebased cleanly. I've been really careful what I've merged.
I'm going to make an attempt between this and #589...
🤞