Add/improve support for Path dependencies and GIT dependencies #712
Conversation
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Need to add a test for subdirectory. |
|
I suspect the micromamba test failures may be due to the release of micromamba 2.0 |
Noooooo! 😱 I wanted to release! Ok, I guess we have more work. Regarding this PR, it looks mostly great. One of my big concerns is favoring Poetry-style parse_python_requirement("/path/to/some-package", manager="pip", mapping_url=DEFAULT_MAPPING_URL)Looking forward to the additional test for |
|
Ok, micromamba v2 was not so bad. I believe I took care of it in #713. Feel free to rebase on main, and I hope that will fix things. |
romain-intel
force-pushed
the
feat/improve-poetry-support
branch
from
247d1cb
to
8fa77b4
Compare
|
Hopefully that works -- the PEP for local requirements seems to be |
|
On first glance this looks great, thanks so much @romain-intel!!! Note one hiccup in the doctest with a missing |
|
whoops. Sorry about that. Hopefully that will do it. Unrelated: I see a flurry of activity, planning a release soon? |
|
Gah -- something up with windows :( . I can't seem to retrigger tests but I think everything else should be fine :). |
|
Oops, #717 should fix it. Could you please rebase again? |
Yes, I really want to get this released as soon as possible. There are a few tricky things though. The release of micromamba 2 is still causing a lot of chaos, e.g. #709, so we should probably let that settle down a bit first. |
Specifically: - adds subdirectory for GIT dependencies - adds the ability to pass "path" dependencies to Poetry
romain-intel
force-pushed
the
feat/improve-poetry-support
branch
from
70c4159
to
c65d095
Compare
|
Rebased. And yes, micromamba v2 is also causing me headaches :). Hopefully you can release soon though. Definitely interested in getting this large change integrated. |
There was a problem hiding this comment.
This looks good to me, are you ready to merge @romain-intel?
|
I'm going to take all the green I can get and merge this. Feel free to do any followup in a subsequent PR. |
Specifically:
Description
This simply extends support of the arguments that conda-lock can parse in a pyproject.toml and passes them down to Poetry. Specifically it adds support for local directories and wheels as well as support for #subdirectory in GIT packages.