Convert script and directory _nsis.py subcommands into NSIS code
#1069
+78
−151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
3 tasks
|
@marcoesters Is this something that is awaiting review? Let me know and I can review it. |
You are free to leave comments, but in the end, I need approval from a |
lrandersson
reviewed
Sep 30, 2025
| call un.AbortRetryNSExecWait | ||
| ${EndIf} | ||
| !insertmacro AbortRetryNSExecWaitLibNsisCmd "rmpath" | ||
| !insertmacro AbortRetryNSExecWaitLibNsisCmd "rmreg" |
There was a problem hiding this comment.
It was actually never needed. The uninstallation via conda-standalone already performs the same function during the installation process. I included that line back then by mistake.
Co-authored-by: Robin <34315751+lrandersson@users.noreply.github.com>
|
I found a way to remove the |
lrandersson
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert simple script and directory subcommands into NSIS code to further decouple the python dependency from EXE installers (#549). Scripts are already executed directly via
cmd.exefor pre-install scripts andmkdirsis a simple directory creation command.Note that this means that
post-installandpre-uninstallscript failures will cause the installation/uninstallation process to fail now. I think this is good behavior as it has masked issues in the past (see #942 and #1020).Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?