-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add comment to identified license if match is not perfect #303
Comments
The match will never be perfect, so it will always need to add that comment |
Reopening that just because it still needs to add the comment |
It seems to me that grayskull should not put too weak assumptions into the generated recipe. In my case, I'm running grayskull over an sdist with a proprietary license, but grayskull does
and puts
into the recipe. While of course the LICENSE.txt should be the final (correct) truth, putting this down as a |
Additionally, I've found no way to override the license detector when invoking grayskull, which could be a stopgap measure to avoid putting wrong metadata in the recipe. Is there one already that I missed? |
For anybody finding this in the future, one workaround I found when using
|
Is your feature request related to a problem? Please describe.
grayskull
will identify licenses by fuzzy match in some cases and then suggest the best result. However, sometimes the fuzzy match scores a bit lower than average because some people modify popular licenses like BSD or MIT and add their own clauses. This kind of change will turn those into a different license altogether, which should be named asLicenseRef-packagename
.Describe the solution you'd like
I suggest:
license: MIT # warning! license might have been modified; search match is XX%
.LicenseRef-packagename
identifier with a comment next to it like# license could not be identified, please review
.Describe alternatives you've considered
Erroring out seems excessive.
Additional context
A recent example I found on a conda-forge submission.
The text was updated successfully, but these errors were encountered: