Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display warning about license match percentage #305

Merged
merged 4 commits into from
Feb 23, 2022

Conversation

ForgottenProgramme
Copy link
Contributor

Fixes #303 (partly)

Grayskull uses rapidfuzz to do the matching between the package license and a set of standard licenses stored in grayskull/license/data.
I have added a warning to inform the user about how close the 'License Type' (as mentioned in the recipe and displayed in the console) is to the actual license found in the package metadata.
As mentioned in the linked issue and as discussed with @marcelotrevisani, the next step should be to add a comment about the match percentage within the recipe.

ForgottenProgramme and others added 2 commits February 23, 2022 21:49
Co-authored-by: Marcelo Duarte Trevisani <marcelotrevisani@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #305 (78e0344) into main (9c3242e) will increase coverage by 0.25%.
The diff coverage is 93.77%.

❗ Current head 78e0344 differs from pull request most recent head d80e823. Consider uploading reports for the commit d80e823 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   91.30%   91.56%   +0.25%     
==========================================
  Files          17       16       -1     
  Lines        1576     1517      -59     
==========================================
- Hits         1439     1389      -50     
+ Misses        137      128       -9     
Flag Coverage Δ
unittests 91.56% <93.77%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)
grayskull/license/discovery.py 95.67% <54.54%> (-1.47%) ⬇️
grayskull/strategy/abstract_strategy.py 83.33% <83.33%> (ø)
grayskull/utils.py 89.67% <86.08%> (-10.33%) ⬇️
grayskull/base/github.py 88.67% <88.67%> (ø)
grayskull/__main__.py 95.29% <92.10%> (-2.86%) ⬇️
grayskull/base/factory.py 91.17% <93.33%> (+1.17%) ⬆️
grayskull/strategy/py_base.py 95.45% <95.45%> (ø)
grayskull/config.py 96.66% <96.66%> (ø)
grayskull/strategy/pypi.py 98.72% <98.72%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac15e45...d80e823. Read the comment docs.

@marcelotrevisani
Copy link
Member

Cool! Thanks a lot for your contribution again! :)
🚀🚀🚀

@marcelotrevisani marcelotrevisani merged commit 5710241 into conda:main Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add comment to identified license if match is not perfect
3 participants