Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squeeze out None licenses #392

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Conversation

ocefpaf
Copy link
Contributor

@ocefpaf ocefpaf commented Sep 5, 2022

Grayskull crashes when one of the licenses is None in the all_license_name list. This is probably not the best solution but I thought I should try a PR instead of just opening issues ;-p

@marcelotrevisani
Copy link
Member

Cool! Thanks for that! :)

@codecov-commenter
Copy link

Codecov Report

Merging #392 (30a4b58) into main (9c3242e) will increase coverage by 0.70%.
The diff coverage is 92.82%.

@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
+ Coverage   91.30%   92.01%   +0.70%     
==========================================
  Files          17       16       -1     
  Lines        1576     1703     +127     
==========================================
+ Hits         1439     1567     +128     
+ Misses        137      136       -1     
Flag Coverage Δ
unittests 92.01% <92.82%> (+0.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)
grayskull/base/github.py 72.83% <72.83%> (ø)
grayskull/license/discovery.py 94.87% <78.12%> (-2.28%) ⬇️
grayskull/strategy/abstract_strategy.py 83.33% <83.33%> (ø)
grayskull/__main__.py 95.60% <93.18%> (-2.55%) ⬇️
grayskull/base/factory.py 91.17% <93.33%> (+1.17%) ⬆️
grayskull/strategy/py_base.py 95.00% <95.00%> (ø)
grayskull/config.py 96.96% <96.96%> (ø)
grayskull/utils.py 98.12% <97.58%> (-1.88%) ⬇️
grayskull/strategy/pypi.py 97.68% <97.68%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marcelotrevisani marcelotrevisani merged commit b427f5e into conda:main Sep 5, 2022
@ocefpaf ocefpaf deleted the fix_None_lic branch September 5, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants