Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change license binding #419

Merged
merged 4 commits into from
Dec 2, 2022
Merged

Change license binding #419

merged 4 commits into from
Dec 2, 2022

Conversation

BastianZim
Copy link
Contributor

@BastianZim BastianZim commented Nov 16, 2022

Closes #418

@BastianZim BastianZim marked this pull request as ready for review November 16, 2022 16:14
@BastianZim
Copy link
Contributor Author

Not sure why the tests are failing. I don't think this is connected to this PR.

@marcelotrevisani
Copy link
Member

Sorry, I was on holidays and I didn't check anything during that time, I am back now :)

@marcelotrevisani
Copy link
Member

let me take a look at why the tests are failing, the PR looks good to me

@marcelotrevisani
Copy link
Member

ok, found the problem
gonna fix in this PR if you dont mind

@marcelotrevisani
Copy link
Member

it should be fine now

@BastianZim
Copy link
Contributor Author

No worries, thank you! :)

@BastianZim
Copy link
Contributor Author

Hmm, seems like a GitHub error.

@BastianZim BastianZim closed this Dec 2, 2022
@BastianZim BastianZim reopened this Dec 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022

Codecov Report

Merging #419 (e5bd6a8) into main (9c3242e) will increase coverage by 0.77%.
The diff coverage is 92.86%.

@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   91.30%   92.07%   +0.77%     
==========================================
  Files          17       16       -1     
  Lines        1576     1704     +128     
==========================================
+ Hits         1439     1569     +130     
+ Misses        137      135       -2     
Flag Coverage Δ
unittests 92.07% <92.86%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)
grayskull/base/github.py 72.83% <72.83%> (ø)
grayskull/license/discovery.py 93.81% <72.97%> (-3.33%) ⬇️
grayskull/strategy/abstract_strategy.py 83.33% <83.33%> (ø)
grayskull/__main__.py 95.65% <93.33%> (-2.50%) ⬇️
grayskull/base/factory.py 91.17% <93.33%> (+1.17%) ⬆️
grayskull/strategy/py_base.py 95.43% <95.43%> (ø)
grayskull/utils.py 98.12% <97.58%> (-1.88%) ⬇️
grayskull/strategy/pypi.py 97.68% <97.68%> (ø)
grayskull/config.py 98.50% <98.50%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marcelotrevisani marcelotrevisani merged commit 27cf1ac into conda:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] grayskull separates multiple licenses with & rather than AND
3 participants