Add option to specify a package server mirror; clean up hardcoded URLs throughout codebase #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
FaustinCarter
force-pushed
the
feature_add-option-for-pypi-mirror
branch
from
ca5cca6 to
c0c4ec7
Compare
marcelotrevisani
approved these changes
Aug 4, 2024
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add in new
--pypi-mirror-urland--pypi-metadata-urlCLI options and deprecate--pypi-urlDescription
I want to build conda packages for python packages hosted on an internal package server that follows the pypi.org API. Unfortunately,
https://pypi.orgis hardcoded into thestrategy.pypimodule making this impossible.This PR adds two new options to the
pypiargument parser:--pypi-mirror-url: URL for a mirror intended to replacehttps://pypi.orgthat follows the same API (see Sonatype Nexus, Artifactory, or Gitlab's internal python registry)--pypi-metadata-url: URL from which to pull json metadata about the hosted package (it's possible that a user may want to specify this explicitly if their internal mirror/server does not support thepypi/{package name}/jsonendpointThis PR deprecates the existing
--pypi-urloption, while retaining the original functionality.This PR additionally adds some information to the README about how to use the new options.