Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No dependency hell for contributors #282

Closed
YeungOnion opened this issue Aug 21, 2023 · 6 comments
Closed

No dependency hell for contributors #282

YeungOnion opened this issue Aug 21, 2023 · 6 comments
Assignees
@YeungOnion

Comments

@YeungOnion
Copy link
Contributor

It would be nice to have a way to make contributing easy and portable. I'll work on this and add a mention to it in the Contributing section of the README.
@YeungOnion
Copy link
Contributor Author

I thought of a Dockerfile; if I understood them, Ruben mentioned (in discord chat) making it a pixi project. I don't actually know if the pixi solution would remove the need for docker.

If not, it seems excessive to have an image that has a venv (made and managed by pixi), then run the build within that venv, does it not?

@YeungOnion
Copy link
Contributor Author

Would like to rename the issue to "No dependency hell for contributors"

@baszalmstra
Copy link
Collaborator

I think a pixi project would be great for this repository! It does completely remove the need for docker.

Is this something you want to take on? In that case, Ill assign you so people know you're on it! :)

@baszalmstra baszalmstra changed the title An env for contributions No dependency hell for contributors Aug 21, 2023
@YeungOnion
Copy link
Contributor Author

Yeah, I'll work on it! 🤠

@YeungOnion YeungOnion mentioned this issue Aug 22, 2023
Merged
@wolfv
Copy link
Contributor

wolfv commented Aug 22, 2023

love the title :D

baszalmstra added a commit that referenced this issue Aug 23, 2023
@YeungOnion @baszalmstra
address issue #282 (#283)
fc88e12 
* add as pixi project, mention in contributing readme

added pixi.toml with depends as well as build tasks, made CONTRIBUTING.md mostly added stuff regarding dev.

* Update pixi.toml for other platforms

Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>

* Update pixi.toml for fmt and clippy

Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>

* Update CONTRIBUTING.md

Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>

* Update pixi.toml for approx version syntax

Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>

* Update CONTRIBUTING.md

Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>

* Update README.md

Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>

* Update pixi.toml

Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>

* Update CONTRIBUTING.md

Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>

---------

Co-authored-by: Orion Yeung <11580988+orionyeung001@users.noreply.github.com>
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
@YeungOnion
Copy link
Contributor Author

fixed in #283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YeungOnion YeungOnion

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wolfv @baszalmstra @YeungOnion