Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better parse error message #222

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

baszalmstra
Copy link
Collaborator

Changed the error message for parsing platforms to also include available values:

'foo' is not a known platform.

changed to:

'foo' is not a known platform. Valid platforms are 'noarch', 'linux-32', 'linux-64', 'linux-aarch64', 'linux-armv6l', 'linux-armv7l', 'linux-ppc64le', 'linux-ppc64', 'linux-s390x', 'linux-riscv32', 'linux-riscv64', 'osx-64', 'osx-arm64', 'win-32', 'win-64', 'win-arm64', 'emscripten-32'

@wolfv
Copy link
Contributor

wolfv commented Jun 20, 2023

I still think we should have the option for completely custom platform values (they should follow the {platform}-{arch} schema though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants