-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libsolv_rs #243
Add libsolv_rs #243
Conversation
a075b36
to
79a266b
Compare
Something that we might be interested in is to compile |
crates/libsolv_rs/src/solver/mod.rs
Outdated
) -> Result<u32, Problem> { | ||
level += 1; | ||
|
||
println!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move to tracing::info!
here? Or debug!
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm postponing that because it's a fairly mechanical change and I want to make sure all the truly important stuff is done first
self.pool | ||
.resolve_solvable_inner(literal.solvable_id) | ||
.display() | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as a future idea - this would probably the place to check for a time-budget, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean giving up after a given amount of time? In my eyes the best place for that would be Solver::resolve_dependencies
, which is using Solver::set_propagate_learn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, like setting a limit of 1 sec, or 10'000 iterations ...
crates/rattler_solve/Cargo.toml
Outdated
@@ -23,8 +23,10 @@ url = "2.4.0" | |||
hex = "0.4.3" | |||
tempfile = "3.6.0" | |||
cfg-if = "1.0.0" | |||
libsolv_rs = { version = "0.1.0", path = "../libsolv_rs" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we put both implementations behind feature flags.
3956489
to
ce24cf0
Compare
ce24cf0
to
ba7689b
Compare
cb8c03a
to
6ce282b
Compare
No description provided.