Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: workaround for PIP_REQUIRE_VIRTUALENV env variable #294

Merged
merged 2 commits into from
Aug 27, 2023
Merged

fix: workaround for PIP_REQUIRE_VIRTUALENV env variable #294

merged 2 commits into from
Aug 27, 2023

Conversation

tusharsadhwani
Copy link
Contributor

If PIP_REQUIRE_VIRTUALENV is set to true in the user's environment, maturin develop fails because the pip subcommand doesn't recognize the env as a venv.

This works around that.

@wolfv
Copy link
Contributor

wolfv commented Aug 25, 2023

Did the --isolated option not work? It might be even better?

@tusharsadhwani
Copy link
Contributor Author

No, --isolated didn't work for me, but you can try to reproduce it to be doubly sure.

Just export PIP_REQUIRE_VIRTUALENV=true in your shell to reproduce the error.

@wolfv wolfv merged commit 45126b9 into conda:main Aug 27, 2023
8 checks passed
@tusharsadhwani tusharsadhwani deleted the require-venv branch August 28, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baszalmstra baszalmstra baszalmstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tusharsadhwani @wolfv @baszalmstra