refactor: lock-file v4 #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rattler-lock has been completely overhauled to include a new file format that much better serves our goals. It allows storing multiple environments and includes the complete PackageRecord information.
ruben-arts
reviewed
Jan 18, 2024
baszalmstra
force-pushed
the
refactor/rattler_lock_v4
branch
from
d511d43
to
c004992
Compare
ruben-arts
reviewed
Jan 23, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
ruben-arts
pushed a commit
to prefix-dev/pixi
that referenced
this pull request
Jan 23, 2024
Refactors pixi to make use of the changes made in conda/rattler#484 . This completely refactors how lock-files are checked and how they are rebuilt. @ruben-arts Please carefully test that lock-files are still properly verified and updated. Note that this does **not** add multi-env support yet. This work is just done to integrate with multi-env capable lock-files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely refactors the lock-file implementation in
rattler-locksignificantly changing the format. Old lock-files can still be read by the current implementation.The goal of the refactor is to allow multiple environments to be stored in the lock-file as well as significantly simplifying the format itself.
See the top-level crate documentation for more information about the design and considerations.
@ruben-arts I also added behavior to write packages non-alphabetic but in a more "human-readable" friendly style.
Note
This significantly deviates from our previous implementation loosely based on conda-lock.
The code is still able to parse
conda-lock.ymlfiles! Its just not able to output a compatible conda-lock file.Note that this has already been the case for a long time but the differences didn't used to be so big.
Important
This PR is still in previous because I want to first test out the API in Pixi. Nonetheless, reviews are already welcome!
I also realize this is a huge change, Id be happy to walk anyone through the code on discord!
Closes #465