Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump zip to 2.1.3 #772

Merged
merged 2 commits into from
Jul 8, 2024
Merged

chore: bump zip to 2.1.3 #772

merged 2 commits into from
Jul 8, 2024

Conversation

jpcorreia99
Copy link
Contributor

Sometimes fetching packages using rattler fails with ZipError: "The file length is not available in the local header".

This error comes from the zip library here:

https://github.com/zip-rs/zip2/blame/b6e0a0693ba2d07f541cd9017b60df7e65817e48/src/types.rs#L688-L696

As can be seen in a comment

/* FIXME: these were previously incorrect: add testing! */
        /* flags & (1 << 3) != 0 */

Bumping the version of zip has solved our issues and we're able to install the desired packages.

@jpcorreia99 jpcorreia99 changed the title Bump zip to 2.1.3 chore: Bump zip to 2.1.3 Jul 8, 2024
@jpcorreia99
Copy link
Contributor Author

@baszalmstra / @wolfv hey there, I'd appreciate a review here whenever you have the time for it!

@wolfv
Copy link
Contributor

wolfv commented Jul 8, 2024

nice find. Thanks so much!

@wolfv
Copy link
Contributor

wolfv commented Jul 8, 2024

@nichmor does this include your fix as well?

Copy link
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

crates/rattler_package_streaming/src/write.rs Outdated Show resolved Hide resolved
@baszalmstra baszalmstra changed the title chore: Bump zip to 2.1.3 chore: bump zip to 2.1.3 Jul 8, 2024
@nichmor
Copy link
Contributor

nichmor commented Jul 8, 2024

@nichmor does this include your fix as well?

no, mine it's not merged yet

@wolfv wolfv merged commit ead5201 into conda:main Jul 8, 2024
15 checks passed
@baszalmstra baszalmstra mentioned this pull request Jul 8, 2024
baszalmstra added a commit that referenced this pull request Jul 15, 2024
## 🤖 New release
* `file_url`: 0.1.2 -> 0.1.3
* `rattler`: 0.26.5 -> 0.27.0
* `rattler_cache`: 0.1.1 -> 0.1.2
* `rattler_conda_types`: 0.26.0 -> 0.26.1
* `rattler_digest`: 0.19.4 -> 0.19.5
* `rattler_package_streaming`: 0.21.4 -> 0.21.5
* `rattler_networking`: 0.20.9 -> 0.20.10
* `rattler_shell`: 0.21.0 -> 0.21.1
* `rattler_lock`: 0.22.13 -> 0.22.14
* `rattler_repodata_gateway`: 0.21.0 -> 0.21.1
* `rattler_solve`: 0.25.0 -> 0.25.1
* `rattler_libsolv_c`: 0.19.4 -> 0.19.5
* `rattler_virtual_packages`: 0.19.16 -> 0.19.17
* `rattler_index`: 0.19.18 -> 0.19.19

<details><summary><i><b>Changelog</b></i></summary><p>

## `file_url`
<blockquote>

##
[0.1.3](file_url-v0.1.2...file_url-v0.1.3)
- 2024-07-15

### Other
- update Cargo.toml dependencies
</blockquote>

## `rattler`
<blockquote>

##
[0.27.0](rattler-v0.26.5...rattler-v0.27.0)
- 2024-07-15

### Fixed
- unclobber issue when packages are named differently
([#776](#776))

### Other
- bump dependencies and remove unused ones
([#771](#771))
</blockquote>

## `rattler_cache`
<blockquote>

##
[0.1.2](rattler_cache-v0.1.1...rattler_cache-v0.1.2)
- 2024-07-15

### Other
- bump dependencies and remove unused ones
([#771](#771))
</blockquote>

## `rattler_conda_types`
<blockquote>

##
[0.26.1](rattler_conda_types-v0.26.0...rattler_conda_types-v0.26.1)
- 2024-07-15

### Other
- PrefixRecord deserialization using simd
([#777](#777))
</blockquote>

## `rattler_digest`
<blockquote>

##
[0.19.5](rattler_digest-v0.19.4...rattler_digest-v0.19.5)
- 2024-07-15

### Other
- bump dependencies and remove unused ones
([#771](#771))
</blockquote>

## `rattler_package_streaming`
<blockquote>

##
[0.21.5](rattler_package_streaming-v0.21.4...rattler_package_streaming-v0.21.5)
- 2024-07-15

### Other
- bump zip to 2.1.3
([#772](#772))
</blockquote>

## `rattler_networking`
<blockquote>

##
[0.20.10](rattler_networking-v0.20.9...rattler_networking-v0.20.10)
- 2024-07-15

### Other
- bump dependencies and remove unused ones
([#771](#771))
</blockquote>

## `rattler_shell`
<blockquote>

##
[0.21.1](rattler_shell-v0.21.0...rattler_shell-v0.21.1)
- 2024-07-15

### Other
- update Cargo.toml dependencies
</blockquote>

## `rattler_lock`
<blockquote>

##
[0.22.14](rattler_lock-v0.22.13...rattler_lock-v0.22.14)
- 2024-07-15

### Other
- bump dependencies and remove unused ones
([#771](#771))
</blockquote>

## `rattler_repodata_gateway`
<blockquote>

##
[0.21.1](rattler_repodata_gateway-v0.21.0...rattler_repodata_gateway-v0.21.1)
- 2024-07-15

### Other
- bump dependencies and remove unused ones
([#771](#771))
</blockquote>

## `rattler_solve`
<blockquote>

##
[0.25.1](rattler_solve-v0.25.0...rattler_solve-v0.25.1)
- 2024-07-15

### Other
- update Cargo.toml dependencies
</blockquote>

## `rattler_libsolv_c`
<blockquote>

##
[0.19.5](rattler_libsolv_c-v0.19.4...rattler_libsolv_c-v0.19.5)
- 2024-07-15

### Other
- bump dependencies and remove unused ones
([#771](#771))
</blockquote>

## `rattler_virtual_packages`
<blockquote>

##
[0.19.17](rattler_virtual_packages-v0.19.16...rattler_virtual_packages-v0.19.17)
- 2024-07-15

### Other
- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_index`
<blockquote>

##
[0.19.19](rattler_index-v0.19.18...rattler_index-v0.19.19)
- 2024-07-15

### Other
- updated the following local packages: rattler_conda_types,
rattler_digest, rattler_package_streaming
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants