fix: topological sort when cycles appear in leaf nodes #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
force-pushed
the
fix-topological-sort
branch
from
a335502
to
fb6a203
Compare
wolfv
force-pushed
the
fix-topological-sort
branch
from
fb6a203
to
3846761
Compare
wolfv
commented
Oct 1, 2024
| if p1_noarch && !p2_noarch { | ||
| cycle_breaks.insert((pi1.clone(), pi2.clone())); | ||
| break; | ||
| } else if !p1_noarch && p2_noarch { | ||
| } else if !p1_noarch && p2_noarch || i == cycle.len() - 1 { |
There was a problem hiding this comment.
Note the added condition here to also return a cycle break if none of the packages is noarch and we're in the last iteration.
baszalmstra
approved these changes
Oct 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues with our topological sort implementation:
The changes came up because a user was installing
holoviewswhich has a circular dependency onpanel. It failed later in the un-clobbering (because some packages were just missing after the topological sort because of this faulty "root" detection).