refactor: parse matchspec url into NamedChannelOrUrl [skip ci] #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps we should have a "ResolvedMatchSpec" and a non-resolved one. Also a big refactor.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be good to stop the weird channel parsing in matchspecs because it's subtly wrong. We always create a "default" channel config.
However, now we have two problems:
matches(...)function needs a secondmatches_with_channel_config(...)function or a second parameter with a optional channel config to properly evaluate the channels from config.Wanted to ask for early feedback before going down this path further.