Improve WorkflowTaskExecutor logic to create a

failed task instead of raising an Exception
conductor-sdk · May 11, 2023 · 0b01347 · 0b01347
1 parent 31aec6b
commit 0b01347
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/Conductor/Client/Worker/WorkflowTaskExecutor.cs b/Conductor/Client/Worker/WorkflowTaskExecutor.cs
@@ -1,4 +1,5 @@
 using Conductor.Client.Interfaces;
+using Conductor.Client.Extensions;
 using Microsoft.Extensions.Logging;
 using System;
 using System.Collections.Generic;
@@ -140,15 +141,14 @@ private void ProcessTask(Models.Task task)
             try
             {
                 var taskResult = _worker.Execute(task);
-                taskResult.WorkerId = _workerSettings.WorkerId;
-                UpdateTask(taskResult);
                 _logger.LogTrace(
                     $"[{_workerSettings.WorkerId}] Done processing task for worker"
                     + $", taskType: {_worker.TaskType}"
                     + $", domain: {_workerSettings.Domain}"
                     + $", taskId: {task.TaskId}"
                     + $", workflowId: {task.WorkflowInstanceId}"
                 );
+                UpdateTask(taskResult);
             }
             catch (Exception e)
             {
@@ -159,6 +159,8 @@ private void ProcessTask(Models.Task task)
                     + $", taskId: {task.TaskId}"
                     + $", workflowId: {task.WorkflowInstanceId}"
                 );
+                var taskResult = task.Failed(e.Message);
+                UpdateTask(taskResult);
             }
             finally
             {
@@ -168,6 +170,7 @@ private void ProcessTask(Models.Task task)
 
         private void UpdateTask(Models.TaskResult taskResult)
         {
+            taskResult.WorkerId = taskResult.WorkerId ?? _workerSettings.WorkerId;
             for (var attemptCounter = 0; attemptCounter < UPDATE_TASK_RETRY_COUNT_LIMIT; attemptCounter += 1)
             {
                 try