[DRE-94] Add tests #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcarrero
approved these changes
Jun 6, 2023
fcarrero
requested changes
Jun 6, 2023
| pass | ||
| accept_language = 'es' | ||
| response = self.api.get_orders(accept_language, limit=20) | ||
| self.assertIsNotNone(response) |
There was a problem hiding this comment.
podemos validar aca que el charges[0].payment_method si es cash, card o spei ?
There was a problem hiding this comment.
y asi para todos los casos en donde usemos oneof o anyof o oneof
fcarrero
reviewed
Jun 6, 2023
setup.py
Outdated
| @@ -33,7 +33,7 @@ | |||
| name=NAME, | |||
| version=VERSION, | |||
| description="Conekta API", | |||
| author="Api support client", | |||
| author="Engineering Conekta", | |||
| author_email="engineering@conekta.com", | |||
| url="https://developers.conekta.com/", | |||
There was a problem hiding this comment.
aca porfa cambiar por este valor
https://github.com/conekta/conekta-python
fcarrero
reviewed
Jun 6, 2023
| @@ -33,7 +33,7 @@ | |||
| name=NAME, | |||
There was a problem hiding this comment.
porfa el name dejarlol 'conekta'
para conservar el mismo name que ya se tiene en pip
There was a problem hiding this comment.
Ahora esta como conekta-python, lo cambio a conekta?
|
podemos conservar el https://github.com/conekta/conekta-python/blob/master/CHANGELOG.md |
fcarrero
reviewed
Jun 6, 2023
fcarrero
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.