Skip to content

Commit

Permalink
test/e2e: ibmcloud: Security alert
Browse files Browse the repository at this point in the history
CodeQL is throwing up a high severity error:
> Sensitive information that is logged unencrypted is
> accessible to an attacker who gains access to the logs.

Longer term we might want to log selective fields, or
provider a way to just hide the sensitive fields, but for now
I've just removed the debug logs that expose things like API Keys

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
  • Loading branch information
stevenhorsman authored and wainersm committed Nov 28, 2024
1 parent 819425f commit ac6e23f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,6 @@ func InitIBMCloudProperties(properties map[string]string) error {
IBMCloudProps.IsSelfManaged = true
}

log.Debugf("%+v", IBMCloudProps)

if len(IBMCloudProps.ResourceGroupID) <= 0 {
log.Info("[warning] RESOURCE_GROUP_ID was not set.")
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ func (lio *IBMCloudInstallOverlay) Delete(ctx context.Context, cfg *envconf.Conf

// Update install/overlays/ibmcloud/kustomization.yaml
func (lio *IBMCloudInstallOverlay) Edit(ctx context.Context, cfg *envconf.Config, properties map[string]string) error {
log.Debugf("%+v", properties)
var err error

// image
Expand Down

0 comments on commit ac6e23f

Please sign in to comment.