Bump artifact versions in caa multi arch build #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump the download-artifact and upload-artifact versions to v4 and fix the naming issues Signed-off-by: stevenhorsman <steven@uk.ibm.com>
With the actions/upload-artifact@v4 artifacts that are uploaded need unique names. Previously the tag.txt was uploading in all the matrix steps resulting in duplications, so separate it out as a pre-job which follows the same logic as before and then pull the tag.txt in a separate step from the arch specific files back together in the manifest job. Signed-off-by: stevenhorsman <steven@uk.ibm.com>
mkulke
approved these changes
Oct 7, 2024
stevenhorsman
merged commit 51d51c7
into
confidential-containers:main
18 of 19 checks passed
stevenhorsman
deleted the
bump-artifact-versions-in-caa-multi-arch-build
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable the upload-artifact and download-artifact version bumps and fix the workflow and script changes that meant there were non-unique file names being used.
The workflow running in my fork (with an additional commit to make the CAA build have a workflow dispatch for easier running): https://github.com/stevenhorsman/cloud-api-adaptor/actions/runs/11216651939/job/31176425619