test: don't use gh cli in kbs checkout #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we clone the repo we can use git to resolve a tag/branch to a sha. We probably want to avoid using gh cli in places where it's not required, because it involves setting secrets and makes executing tests more cumbersome. There could also be breakage if people specify a fork as KBS_REPO, since we use the gh cli with a hardcoded repository. Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
stevenhorsman
approved these changes
Oct 11, 2024
wainersm
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we clone the repo we can use git to resolve a tag/branch to a sha. We probably want to avoid using gh cli in places where it's not required, because it involves setting secrets and makes executing tests more cumbersome. There could also be breakage if people specify a fork as KBS_REPO, since we use the gh cli with a hardcoded repository.