Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Pin the terraform lint runner #2120

Conversation

stevenhorsman
Copy link
Member

Github are updating their default ubuntu-latest runner from 22.04 to 24.04: actions/runner-images#10636 The 24.04 image doesn't have terraform installed, so this breaks the terraform linting. Pin this at the old version to fix this.

The other linting jobs pass on 24.04, so pin these at 24.04, so we don't have a repeat of this in two years time (accidentally)

@stevenhorsman
Copy link
Member Author

FYI: I was tempted to pin all the ubuntu-latest runs-on in this PR, but I figure doing them one file at a time was probably safer.

Copy link
Member

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stevenhorsman !

Github are updating their default ubuntu-latest runner from
22.04 to 24.04: actions/runner-images#10636
The 24.04 image doesn't have terraform installed, so this breaks the
terraform linting. Pin this at the old version to fix this.

The other linting jobs pass on 24.04, so pin these at 24.04, so
we don't have a repeat of this in two years time (accidentally)

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
@stevenhorsman stevenhorsman merged commit 4010a6b into confidential-containers:main Oct 16, 2024
19 checks passed
@stevenhorsman stevenhorsman deleted the linting-gh-runner-pinning branch November 28, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants