Skip to content

Commit

Permalink
keyprovider: Pin a specific version of skopeo
Browse files Browse the repository at this point in the history
The dependency on skopeo is quite fragile as there are several versions
of the project that would generate an encrypted image with a gzip header
that Confidential Containers simply cannot deal with.

For now, let's use f64a376, from Aug 14th 2024 as, empirically, we know
that it works.

We must have tests implemented in order to cover the documentation we
provide, and whether it works or not.

Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
  • Loading branch information
fidencio committed Aug 18, 2024
1 parent 909fe14 commit 9d89c25
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion attestation-agent/docker/Dockerfile.keyprovider
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,13 @@ RUN apt-get update && apt-get install -y \
pkg-config
RUN git clone https://github.com/containers/skopeo $GOPATH/src/github.com/containers/skopeo
WORKDIR $GOPATH/src/github.com/containers/skopeo
RUN git checkout v1.14.1
# The dependency on skopeo is quite fragile as there are several versions of
# the project that would generate an encrypted image with a gzip header that
# Confidential Containers simply cannot deal with.
#
# For now, let's use f64a376, from Aug 14th 2024 as, empirically, we know that
# it works.
RUN git reset --hard f64a376
ENV DISABLE_DOCS=1
RUN make bin/skopeo
RUN make install
Expand Down

0 comments on commit 9d89c25

Please sign in to comment.