-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDH: credentials should be optional in the configuration toml #514
Comments
Xynnn007
added a commit
to Xynnn007/guest-components
that referenced
this issue
Mar 22, 2024
This commit gets rid of unwrap() in parsing CDH's config and will result in an error. Also, this commit adds support for a configuration file without any [[credentials]] array member. To ensure the config behavior is as expected, adds some unit tests. Fixes confidential-containers#514 Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Merged
Hi @wainersm, thanks for bringing this up. TOML crate seems not intelligent enough to handle empty arrays thus I explicitly fix that in a PR. BTW, |
Xynnn007
added a commit
that referenced
this issue
Mar 22, 2024
This commit gets rid of unwrap() in parsing CDH's config and will result in an error. Also, this commit adds support for a configuration file without any [[credentials]] array member. To ensure the config behavior is as expected, adds some unit tests. Fixes #514 Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm trying to launch cdh configured for
offline_fs_kbc
where I don't want to load any credentials but I'm gettingmissing field \
credentials`` errors.Here is the configuration file and execution output:
Then I added an empty
[credentials]
section to the toml file and got another error:Alright, an empty
[[credentials]]
didn't work either because now it requiresresource_uri
andpath
...The text was updated successfully, but these errors were encountered: