Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.toml: add occlum cckbc feature #144

Merged
merged 2 commits into from
May 9, 2023
Merged

Cargo.toml: add occlum cckbc feature #144

merged 2 commits into from
May 9, 2023

Conversation

Xynnn007
Copy link
Member

@Xynnn007 Xynnn007 commented May 9, 2023

This new feature is used inside encalve-cc to integrate cc-kbc and generic-kbs

add "ocicrypt-rs/block-cipher" for feature encryption

delete "keywrap-jwe" for ocicrypt-rs

Close #143

This new feature is used inside encalve-cc to integrate cc-kbc
and generic-kbs

add "ocicrypt-rs/block-cipher" for feature `encryption`

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
As JWE is not usually used in CoCo system, we define another feature
`keywrap-jwe` to control the on-off of JWE.

CI updated too

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Copy link
Member

@arronwy arronwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Xynnn007 , LGTM!
BTW, do we need test case for enclave-cc-cckbc-* ?

@Xynnn007
Copy link
Member Author

Xynnn007 commented May 9, 2023

@arronwy It will be great to have one but hard to implement in image-rs. We will have an test in enclave-cc to cover the whole process. We can left this in future if needed

@Xynnn007 Xynnn007 merged commit 44f27c2 into confidential-containers:main May 9, 2023
@Xynnn007 Xynnn007 deleted the feat-occlum-cckbc branch May 9, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of jwe for ocicrypt-rs
2 participants