Adjusted the handling of URLs to support more types of hosts #173
Conversation
|
cc @sameo |
| @@ -17,7 +17,7 @@ pub mod types; | |||
| const KBS_REQ_TIMEOUT_SEC: u64 = 60; | |||
| const KBS_GET_RESOURCE_MAX_ATTEMPT: u64 = 3; | |||
|
|
|||
| pub const KBS_URL_PREFIX: &str = "kbs/v0"; | |||
| pub const KBS_URL_PREFIX: &str = "/kbs/v0"; | |||
There was a problem hiding this comment.
maybe KBS_RESOURCE_PREFIX is better?
There was a problem hiding this comment.
The prefix here is not only used to obtain resources, but also to obtain tokens in the passport model. Perhaps we can just call it KBS_PREFIX.
| @@ -93,10 +93,10 @@ impl KbsProtocolWrapper { | |||
| &mut self.http_client | |||
| } | |||
|
|
|||
| async fn attestation(&mut self, kbs_host_url: String) -> Result<String> { | |||
| async fn attestation(&mut self, kbs_root_url: String) -> Result<String> { | |||
There was a problem hiding this comment.
maybe use kbs_url directly which contains the scheme://domain-name[:port][/user]
There was a problem hiding this comment.
In many domain name allocation scenario, the root domain name assigned to KBS may have a more complex form. I believe we should leave enough flexibility for the form of the root domain name. Therefore, for now, I suggest not defining and resolving the format and content of the root domain name.
There was a problem hiding this comment.
maybe use
kbs_urldirectly which contains thescheme://domain-name[:port][/user]
If we use kbs_url here, it may be confused with the whole resource url.
Currently, our default host URL format for KBS is http://IP:PORT, But in productization, we may give host URL more forms. For example: http://my-kbs.com , http://my-kbs.com/user-alice Therefore, it is necessary to expand the supported KBS host URL format, More precisely, it should no longer be referred to as the "host URL", but rather as the "root URL". Signed-off-by: Jiale Zhang <zhangjiale@linux.alibaba.com>
Currently, our default host URL format for KBS is http://IP:PORT, But in productization, we may give host URL more forms. For example: http://my-kbs.com , http://my-kbs.com/user-alice Therefore, it is necessary to expand the supported KBS host URL format, More precisely, it should no longer be referred to as the "host URL", but rather as the "root URL".