Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made Attester trait's get_evidence() async #299

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Made Attester trait's get_evidence() async #299

merged 1 commit into from
Jul 28, 2023

Conversation

mkulke
Copy link
Contributor

@mkulke mkulke commented Jul 27, 2023 •
edited
Loading

fixes #298

@mkulke mkulke requested a review from jialez0 as a code owner July 27, 2023 08:41
Xynnn007
Xynnn007 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Xynnn007
Copy link
Member

@mkulke the error is caused by the pr.

@mkulke mkulke force-pushed the mkulke/make-attester-trait-async branch from 1612be1 to b9992b1 Compare July 27, 2023 14:23
fitzthum
fitzthum approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xynnn007
Copy link
Member

hi @mkulke plz rebase this

@mkulke
Made Attester trait's get_evidence() async
52db6df 
Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
@mkulke mkulke force-pushed the mkulke/make-attester-trait-async branch from b9992b1 to 52db6df Compare July 28, 2023 07:51
@Xynnn007 Xynnn007 merged commit 709a6b0 into confidential-containers:main Jul 28, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xynnn007 Xynnn007 Xynnn007 approved these changes

@fitzthum fitzthum fitzthum approved these changes

@jialez0 jialez0 Awaiting requested review from jialez0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

attestation-agent: Attester trait should be async
3 participants
@mkulke @Xynnn007 @fitzthum