Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CDH & kbs_protocol #381

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Conversation

Xynnn007
Copy link
Member

@Xynnn007 Xynnn007 commented Oct 26, 2023

When doing tests with aliyun kms and current guest components, we found some bugs and this fix will help.

cc @arronwy @mozillazg

In practice we found that there is a time during which kata-agent is
launched but the network of the pod is not prepared. In such case the
connection request from attestation-agent to KBS would fail because of
there is no network routine to the KBS.

This commit brings a retry mechanism for RCAR handshake. This will help
to resolve the problem.

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Make the provider name recognization case insensitive.

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fitzthum fitzthum merged commit 615a46f into confidential-containers:main Oct 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants