image-rs: change namespace of ICR images #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the namespace of images stored in ICR used for the simple signing XRSS tests. Fixes: confidential-containers#382 Signed-off-by: Matthew Arnold <mattarno@uk.ibm.com>
mattarnoatibm
requested review from
sameo,
jiangliu,
arronwy,
lumjjb,
jialez0 and
Xynnn007
as code owners
|
@stevenhorsman would need to change the |
I've updated it now |
stevenhorsman
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
I've testing this locally with the updated API key and the tests are working for me:
/image-rs# cargo test -p image-rs --no-default-features --features=kata-cc-native-tls,keywrap-jwe,signature-simple-xrss
...
running 2 tests
test signature_verification ... ok
test signature_verification_xrss ... ok
test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 25.00s
|
PR to fix the lint error #390 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the namespace of images stored in ICR used
for the simple signing XRSS tests.
Fixes: #382