AA/kbs_protocol: fix the RCAR handshake unit test #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some changes upon KBS side. https://github.com/confidential-containers/kbs/pull/265/files#diff-88f80dee1e5f367cb319573b2d524906c5631100a0a3ce6cc62bf2ebf62fb251L95 replaces token type to a token config, and we do not have a default token config builder thus we need to explicitly add the attestation_token_config. Also, the commit confidential-containers/trustee@43d56f3 will block the sample_attester by the default policy of KBS when verifying the CoCoAS token. This is due to security. But in this test, we leverage sample-attester, so we need a policy that allows this. The commit confidential-containers@006e1ff enables sample_attester without setting environment variable. Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
fitzthum
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some changes upon KBS side.
https://github.com/confidential-containers/kbs/pull/265/files#diff-88f80dee1e5f367cb319573b2d524906c5631100a0a3ce6cc62bf2ebf62fb251L95 replaces token type to a token config, and we do not have a default token config builder thus we need to explicitly add the attestation_token_config.
Also, the commit
confidential-containers/trustee@43d56f3 will block the sample_attester by the default policy of KBS when verifying the CoCoAS token. This is due to security. But in this test, we leverage sample-attester, so we need a policy that allows this.
The commit
006e1ff enables sample_attester without setting environment variable.
This PR will resolve the blocker in #434 and #436
cc @fitzthum