image-rs: fix integration test #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now use a explicit `none` for KMS_PROVIDER and RESOURCE_PROVIDER in the make file to tell no one will be builtin. In image-rs' integration test, only offline-fs-kbc will be used and that is builtin by default. Thus we do not need to add any extra KMS_PROVIDER or RESOURCE_PROVIDER. See the context in confidential-containers@4e08742 Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Xynnn007
requested review from
sameo,
jiangliu,
arronwy,
lumjjb and
jialez0
as code owners
jialez0
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use a explicit
nonefor KMS_PROVIDER and RESOURCE_PROVIDER in the make file to tell no one will be builtin. In image-rs' integration test, only offline-fs-kbc will be used and that is builtin by default. Thus we do not need to add any extra KMS_PROVIDER or RESOURCE_PROVIDER.See the context in
4e08742