Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdh/docs: bug fix - add build feature for aliyun #528

Merged

Conversation

1570005763
Copy link
Contributor

Building secret_cli without feature specified will generate a binary without functionality.

Signed-off-by: 1570005763 <daniel.duan@linux.alibaba.com>
@1570005763 1570005763 requested a review from sameo as a code owner April 3, 2024 03:29
Copy link
Member

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@Xynnn007
Copy link
Member

Xynnn007 commented Apr 3, 2024

btw, we may need to publish this tool in ORAS. See confidential-containers/trustee#349

@1570005763
Copy link
Contributor Author

btw, we may need to publish this tool in ORAS. See confidential-containers/trustee#349

I'll see what I can do.

@Xynnn007 Xynnn007 merged commit 1a3f0ff into confidential-containers:main Apr 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants