AA: handle multiline content in log events #615
Conversation
There was a problem hiding this comment.
Nice catch. Besides line separators, spaces ' ' are also need to be carefully handled. In the original PR on AS side https://github.com/confidential-containers/trustee/pull/408/files#diff-aa0f7de1cbbcb4efaafaaa30a4b065987cf9d16f1fa01cfdb4e05c1323a1c59eR27 I didnot care about this. Let me fix this issue
Indeed. the first two fields have similar problems, maybe there should be a formal spec document for the log file in the repo, defines which characters are legal, are multiple INIT statements legal, etc... |
The NELR spec doesn't prescribe a format for the `content` payload of an
event. However, since a line break is semantic in the log file, the
content cannot be a multi-line string:
```
content = "one two\nthree four five"
|
v
my-domain my-operation one two
three four five
```
The result would be ambiguous. This change enforces this assertion.
Also added tests for the event log and moved the init log line
generation to the eventlog module (as the digest calc is already there)
Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
mkulke
force-pushed
the
mkulke/handle-multiline-content-in-eventlog
branch
from
906abec
to
88c7d34
Compare
The NELR spec doesn't prescribe a format for the
contentpayload of an event. However, since a line break is semantic in the log file, the content cannot be a multi-line string:The result would be ambiguous. This change enforces this assertion. Also added tests for the event log and moved the init log line generation to the eventlog module (as the digest calc is already there).