attestation-agent: Extend ResourceUri to support query string #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xynnn007
approved these changes
Jul 31, 2024
Comment on lines
175
to
178
| const TEST_QS_URL: &str = "kbs:///plugin/plugname/resourcename?param1=value1¶m2=value2"; | ||
|
|
||
| #[test] | ||
| fn deserialize_qs() { |
There was a problem hiding this comment.
rstest could help to make the tests more dry. I am sure that you will love it : )
There was a problem hiding this comment.
thanks, rstest definitely makes the code cleaner. Let me rework that test case
|
I will update this PR shortly with a edge case I forgot and also the test case clean-up |
With this change, the kbs-client is able to send a get-resource request that includes the query string provided e.g.: kbs-client --url http://127.0.0.1:8080 \ get-resource \ --path 'plugin/nebula/credential?ip[ip]=10.11.12.13&ip[netbits]=21&name=pod1' This is required by the KBS repository plugin interface. Signed-off-by: Claudio Carvalho <cclaudio@linux.ibm.com>
|
Done.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the kbs-client is able to send a get-resource request that includes the query string provided e.g.:
kbs-client --url http://127.0.0.1:8080
get-resource
--path 'plugin/nebula/credential?ip[ip]=10.11.12.13&ip[netbits]=21&name=pod1'
This is required by the KBS repository plugin interface.