Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: fix lint error due to Rust 1.83.0 (stable) update #828

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

Xynnn007
Copy link
Member

@Xynnn007 Xynnn007 commented Dec 2, 2024

No description provided.

@mythi
Copy link
Contributor

mythi commented Dec 2, 2024

just a small nit on the commit message. our contrib guide suggests that code paths are prefixed with a subsystem name so this should probable be: attestation-agent: fix xyz linter error.

does this show up only with some specific features combination or why CI does not pick this up?

This check item starts from Rust 1.83.0

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
This check starts from Rust 1.83.0

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
@mkulke
Copy link
Contributor

mkulke commented Dec 2, 2024

Mostly because the rust toolchain updates. previous successful one https://github.com/confidential-containers/guest-components/actions/runs/12062059299/job/33635128074?pr=824#step:3:118 failed one https://github.com/confidential-containers/guest-components/actions/runs/12113386185/job/33768253307?pr=820#step:3:112

I think Mikko was referring to the missing format checks on commit messages. I don't think the strings themselves are being checked, afaik it's just verified whether the commit msg has a ": " headline

@Xynnn007
Copy link
Member Author

Xynnn007 commented Dec 2, 2024

Do we have a check logic in CI? I've noticed that there is a GHA app https://github.com/marketplace/actions/gs-commit-message-checker

@mythi
Copy link
Contributor

mythi commented Dec 2, 2024

I wasn't thinking about commit message CI checks. The comment about commit messages was just my manual review feedback and the question about CI checks was just that what triggers those changes. Looks like it's because stable now pointing to a new version...

@Xynnn007 Xynnn007 changed the title lint: fix lint error lint: fix lint error due to Rust 1.83.0 (stable) update Dec 2, 2024
@Xynnn007 Xynnn007 merged commit 3589aba into confidential-containers:main Dec 2, 2024
7 checks passed
@Xynnn007 Xynnn007 deleted the fix-lint branch December 2, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants