Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: introduce actionlint and fix findings #315

Conversation

mkulke
Copy link
Contributor

@mkulke mkulke commented Feb 2, 2024

Sorry about the never-ending stream of CI-related PRs, but launching pull_request_target workflows w/ rebases and self-hosted runners is pretty much a shot in the dark (the PRs will run the workflows from the main branch). Actionlint will verify the workflows workflows, so at least obvious problems are caught.

Actionlint will verify the github action workflows

Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
@mkulke mkulke requested a review from sameo as a code owner February 2, 2024 08:06
Copy link
Member

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great tool.

Maybe we only need to run these tests when the workflow files are touched?

@surajssd
Copy link
Member

surajssd commented Feb 7, 2024

Magnus is not around to merge this PR until coming Monday.

@fitzthum fitzthum merged commit 06bc6ea into confidential-containers:main Feb 7, 2024
8 checks passed
@mkulke mkulke deleted the mkulke/add-actionlint-plus-fixes branch February 10, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants