Add write-packages permission for kbs-client-build-and-push workflow #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Porter <porter@ibm.com>
fitzthum
approved these changes
Apr 4, 2024
Xynnn007
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the permission error seen here:
https://github.com/confidential-containers/trustee/actions/runs/8502445853/job/23286620681#step:6:13
Related issue:
Issue #333
Original/merged PR (successfully created staged-images/kbs-client package and sha-based tag but failed to add latest tag):
PR #349
Related github docs suggest to me that the package should have never been uploaded in the first place without this write permission, so I'm not 100% confident in this PR. An alternative might be to have a trustee admin inspect the package settings on the github website (e.g. maybe like this).