Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for detecting changes to flag overrides #101

Merged
merged 4 commits into from
Jan 15, 2024

Conversation

adams85
Copy link
Contributor

@adams85 adams85 commented Jan 15, 2024

Describe the purpose of your pull request

Moves the createFlagOverridesFromMap function to the configcat-common package and adds an optional parameter named watchChanges to the function which controls whether the client should detect changes to the flag override map after client initialization.

Related issues (only if applicable)

https://trello.com/c/9jqzNyAI/381-konzisztencian%C3%B6vel%C5%91-improvementek

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@adams85 adams85 requested a review from a team as a code owner January 15, 2024 12:05
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1ec2efe) 92.71% compared to head (9c48b21) 92.68%.

❗ Current head 9c48b21 differs from pull request most recent head 634adfb. Consider uploading reports for the commit 634adfb to get more accurate results

Files Patch % Lines
src/index.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   92.71%   92.68%   -0.03%     
==========================================
  Files          21       21              
  Lines        2072     2079       +7     
  Branches      562      565       +3     
==========================================
+ Hits         1921     1927       +6     
- Misses        150      151       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adams85 adams85 force-pushed the fix/flag-overrides-watch-changes branch from c240163 to fe881bb Compare January 15, 2024 12:09
@adams85 adams85 force-pushed the fix/flag-overrides-watch-changes branch from 82aac63 to 9c48b21 Compare January 15, 2024 13:56
Copy link

sonarcloud bot commented Jan 15, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adams85 adams85 merged commit 68e2306 into master Jan 15, 2024
16 checks passed
@adams85 adams85 deleted the fix/flag-overrides-watch-changes branch January 15, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants