⚡️ Respond to all queued fetch requests with single response #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randycoulman
force-pushed
the
only-one-config-json-download
branch
from
f1eb3ea to
6ade075
Compare
4 tasks
kp-cat
approved these changes
Sep 5, 2023
randycoulman
force-pushed
the
max-init-wait-time-seconds
branch
from
fccb108 to
6c76bdd
Compare
When performing a fetch, queue up any new requests and then respond to all of the fetches with the result of the pending fetch. This avoids making multiple consecutive fetch requests to the server. Uses a technique I describe in [this blog post](https://blog.sequin.io/genserver-reply-dont-call-us-well-call-you/](https://blog.sequin.io/genserver-reply-dont-call-us-well-call-you/) along with a list of pending callers in the GenServer state.
Allow elapsed time to be equal to wait time instead of strictly greater than.
randycoulman
force-pushed
the
only-one-config-json-download
branch
from
6ade075 to
9e5c418
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
==========================================
- Coverage 96.57% 95.64% -0.94%
==========================================
Files 28 31 +3
Lines 613 734 +121
==========================================
+ Hits 592 702 +110
- Misses 21 32 +11
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is built on top of #102 and the base branch has been set accordingly. I will rebase on latest main before merging.
Describe the purpose of your pull request
When performing a fetch, queue up any new requests and then respond to all of the fetches with the result of the pending fetch.
This avoids making multiple consecutive fetch requests to the server.
Uses a technique I describe in [this blog post](https://blog.sequin.io/genserver-reply-dont-call-us-well-call-you/](https://blog.sequin.io/genserver-reply-dont-call-us-well-call-you/) along with a list of pending callers in the GenServer state.
Related issues (only if applicable)
https://trello.com/c/H6PU0SG0/15-only-one-config-json-download-at-a-time
Requirement checklist (only if applicable)