Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Report a single log of evaluation steps #107

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

randycoulman
Copy link
Collaborator

@randycoulman randycoulman commented Sep 1, 2023

NOTE: This is built on top of #106 and the base branch has been set accordingly. I'll rebase on main before merging.

Describe the purpose of your pull request

Start an Agent to accumulate evaluation log messages in a list, then print a single message at the end with those messages all newline separated.

Note that, contrary to the Ruby SDK, I've continued to log these at the debug level because in the past we've had complaints about how noisy these logs get.

If that is not OK, I can change it.

Related issues (only if applicable)

https://trello.com/c/OCGISNSC/20-merged-evaluation-log

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

Base automatically changed from rename-is-offline to main September 15, 2023 01:51
Start an Agent to accumulate evaluation log messages in a list, then print a single message at the end with those messages all newline separated.

Note that, contrary to the Ruby SDK, I've continued to log these at the `debug` level because in the past we've had complaints about how noisy these logs get.

If that is not OK, I can change it.
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (03d0cc5) 94.68% compared to head (2638369) 94.72%.

❗ Current head 2638369 differs from pull request most recent head 6ca46ee. Consider uploading reports for the commit 6ca46ee to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   94.68%   94.72%   +0.03%     
==========================================
  Files          32       32              
  Lines         753      758       +5     
==========================================
+ Hits          713      718       +5     
  Misses         40       40              
Files Changed Coverage Δ
lib/config_cat/rollout.ex 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randycoulman randycoulman merged commit bbb007d into main Sep 15, 2023
@randycoulman randycoulman deleted the merged-evaluation-log branch September 15, 2023 01:58
@kp-cat kp-cat mentioned this pull request Sep 20, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants