Default user #80
Default user #80
Conversation
…illiseconds postfix to timeouts
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
==========================================
- Coverage 92.65% 92.00% -0.66%
==========================================
Files 19 19
Lines 504 513 +9
==========================================
+ Hits 467 472 +5
- Misses 37 41 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| test "get_value/4 uses the default user if no user is passed", %{client: client} do | ||
| Client.set_default_user(client, User.new("test@test1.com")) | ||
| assert Client.get_value(client, "testStringKey", "") == "fake1" | ||
| end |
There was a problem hiding this comment.
This test seems like a duplicate of the ones in the describe block above, and doesn't seem to belong in a describe block labelled "when the default user is not defined".
There was a problem hiding this comment.
It should mean that the default_user is not predefined in the options. Maybe it would be better if the describe block would be this: "when the default user is not defined in the options"
Describe the purpose of your pull request
get_value()/get_all_values()/get_variation_id()/get_all_variation_ids()methods.set_default_user(user)/clear_default_user()methods to set / remove a default user object used when there's no user passed toget_value()/get_all_values()/get_variation_id()/get_all_variation_ids()methods.connect_timeouttoconnect_timeout_milliseconds(to indicate the unit of measure).read_timeouttoread_timeout_milliseconds(to indicate the unit of measure).Related issues (only if applicable)
https://trello.com/c/XneffR1g/270-default-user-template-2022-09-05-elixir
Requirement checklist (only if applicable)