✨ Implement get_value_details #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 94.39% 94.81% +0.41%
==========================================
Files 24 28 +4
Lines 607 636 +29
==========================================
+ Hits 573 603 +30
+ Misses 34 33 -1
☔ View full report in Codecov by Sentry. |
z4kn4fein
approved these changes
Aug 10, 2023
There were leftover warnings from previous PRs.
Running `mix test --trace` showed several tests that were leaking log output.
Implement new `get_value_details` function. The `EvaluationDetails` struct is fully supported except for the `fetch_time` field, which will come in a follow-up commit.
Simplify OverrideDataSource implementations to return only the flags/settings from the config, and to return an empty map if the settings can't be found/loaded. This fixes a bug: if an override file couldn't be found, we would act as if we had no config at all, but we should still be falling back to the fetched config instead.
Had to do some significant refactoring to get the fetch time out of the cache and to the client where it was needed.
Extracts duplication around handling of fetch times in both ms and as DateTimes.
Extract helpers for extracting the top-level parts of a Config map, and for constructing new configs (for testing).
randycoulman
force-pushed
the
randy/get-value-details
branch
from
894ba56 to
3a4f4c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the purpose of your pull request
Implements the new
get_value_detailsfunction.Also, fixed a bug where, if a LocalFileDataSource file was missing, we'd return
{:error, :not_found}for the entire config. Now, it returns the fetched config with no overrides instead, which matches the behavior of (at least) the Ruby SDK.Related issues (only if applicable)
Provide links to issues relating to this pull request
Requirement checklist (only if applicable)