Minor corrections #2
Conversation
adams85
force-pushed
the
minor-corrections
branch
2 times, most recently
from
832ab4b to
17efa93
Compare
adams85
force-pushed
the
minor-corrections
branch
from
17efa93 to
46003aa
Compare
adams85
force-pushed
the
minor-corrections
branch
8 times, most recently
from
408626a to
9110ba7
Compare
adams85
force-pushed
the
minor-corrections
branch
from
9110ba7 to
9688ece
Compare
src/FlagOverrides.ts
Outdated
| @@ -91,7 +89,7 @@ export interface IQueryStringProvider { | |||
| } | |||
|
|
|||
| class DefaultQueryStringProvider implements IQueryStringProvider { | |||
| get currentValue() { return window?.location.search; } | |||
| get currentValue() { if (typeof location !== "undefined") return location?.search; } | |||
There was a problem hiding this comment.
Maybe an else could be good here just for the eye.
| const transaction = db.transaction(OBJECT_STORE_NAME, "readwrite"); | ||
| const store = transaction.objectStore(OBJECT_STORE_NAME); | ||
| store.put(value, key); | ||
| transaction.oncomplete = () => resolve(); |
There was a problem hiding this comment.
i'm not 100% sure how the transaction works here, but maybe if the store.put completes before this line, the transaction.oncomplete = () => resolve(); will not fire? Just a guess, but maybe it would be safer to put the transaction.oncomplete and onerror before the store.put
There was a problem hiding this comment.
All the JS runtime implementations I know of use an event loop-based, single-threaded execution model. So put doesn't have a chance to fire the complete event before the currently processed JS code finishes.
Regardless, I'll change it, just in case.
src/shared/IndexedDBConfigCache.ts
Outdated
| const store = transaction.objectStore(OBJECT_STORE_NAME); | ||
| const storeRequest = store.get(key); | ||
| let value: string | undefined; | ||
| storeRequest.onsuccess = event => value = (event.target as IDBRequest<any>).result; |
There was a problem hiding this comment.
same here? not sure, just a feeling
|
Describe the purpose of your pull request
Bug fixes:
browserandchrome-extensionplatforms to work correctly in web workers too.DefaultQueryStringProviderto make it work in web workers (aswindowglobal variable is not available web workers.)Breaking changes:
SettingKeyValueto a plain object type. (Very low impact expected. It's unlikely that consumers create instances of this type but even then they may not use the ctor.)FlagOverridesto a plain object type. (Internal breaking change only.)LocalStorageCachetoLocalStorageConfigCacheandChromeLocalStorageCachetoChromeLocalStorageConfigCache. (Internal breaking change only.)Related issues (only if applicable)
n/a
Requirement checklist (only if applicable)